Author loewis
Date 2004-08-12.14:58:38
SpamBayes Score
Marked as misclassified
Logged In: YES 

The patch in itself is fine - it is policy that file name
functions return Unicode strings for unicode arguments.

The test is flawed, though: there is no guarantee that the
string and the Unicode result compare equal (see
nyamatongwe's message) - there isn't even a guarantee that
they compare without raising an exception.

Also, there is currently no guarantee that
unicode-in-unicode-out works on all platforms. For example,
on Windows 95, this hasn't been implemented (and neither on
OS/2). So I would:

a) drop the test checking for equality
b) consider returns-not-unicode a failure only if os.listdir
does return unicode for unicode arguments.
Date User Action Args
2007-08-23 15:39:00adminlinkissue1001604 messages
2007-08-23 15:39:00admincreate