This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dmgass
Recipients
Date 2004-08-17.16:58:04
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=995755

I'm still in the process of implementing the line wrapping
and am gaining a greater appreciation for minimizing the API
(in this process I have been simplifying some of the code).
 Based on this and the feedback so far I am proposing the
following API simplifications:

class HtmlDiff():

I will be making everything protected by convention (adding
a leading underscore) except for the make_file() and
make_table() methods.  This should warn those looking at the
internals that things may change in future releases.  We may
want to consider making additional public interfaces in the
future when more experience is gained.

HtmlDiff.__init__():

1) remove 'smarttabs' argument (I will always expand tabs
using expand_tabs() string method).

HtmlDiff.make_file():
HtmlDiff.make_table():

1) remove 'fromprefix' and 'toprefix' arguments (vast
majority of applications don't need this, for now corner
cases can solve it with a string search/replace algorithm
after the fact).

2) remove 'summary' argument (this added a summary attribute
to the <table> tag and I believe would not be used much if
at all).  A user could always do a string search and replace
on the <table> tag to insert this after the fact.

HtmlDiff.make_file():

1) leave 'title' and 'header' arguments alone (I could be
talked into removing these).  These arguments are for
controlling the window title and any markup to be inserted
just above the table.  Although these could be inserted
after the fact using string search and replace methods I
think these will be commonly used and should be convenient
(plus they are easy to understand).

ANY OTHER API SIMPLIFICATION IDEAS?
History
Date User Action Args
2007-08-23 15:36:27adminlinkissue914575 messages
2007-08-23 15:36:27admincreate