Message45518
Logged In: YES
user_id=80475
Unfortunately, I do not have time to give this more review.
Several thoughts:
- consider making mdiff as private. that will leave its API
flexible to accomodate future changes
- move the templates to private global variables and work to
improve their indentation so that the html is readable
- inline the code for _escape from sax. the three replaces
are not worth the interdependency
- the methods work fine with properly formatted input but
crash badly when the newlines have been stripped. So,
either make the code more flexible or add error handling.
- overall, nice job.
|
|
Date |
User |
Action |
Args |
2007-08-23 15:36:14 | admin | link | issue914575 messages |
2007-08-23 15:36:14 | admin | create | |
|