Message41761
Logged In: YES
user_id=92689
- I'm not sure whether PyObject_CallObject() is the right
idiom here. I would have expected to call cls->tp_new (if
not NULL), but I'm not sure either way.
- I would get rid of the loop counter: you're not using it.
for (;;) will do nicely
- you're XDECREF'ing values of which you know they're not NULL
- idem XINCREF. Also: I'm pretty sure you should incref d at
the end: I think it currently leaks. |
|
Date |
User |
Action |
Args |
2007-08-23 15:18:29 | admin | link | issue643443 messages |
2007-08-23 15:18:29 | admin | create | |
|