This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Mark.Shannon
Recipients Mark.Shannon
Date 2022-02-15.14:17:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1644934628.87.0.437399260946.issue46760@roundup.psfhosted.org>
In-reply-to
Content
<rant>

This is getting really annoying.
It takes longer to fix all the heavily coupled and poorly written tests in test_dis than to make the real changes.

Tiny changes in the calling sequence, or reordering CFGs, cause huge diffs in the test_dis module.
No one ever checks these changes, they are just noise.

I've put this under "enhancement" as there is no "wastes a huge amount of time" category.

</rant>

The test_dis should not:

Contain offsets; they turn one line diffs into 100 line diffs
Contain tests for the compiler; they belong elsewhere.
Contain big strings; write proper tests not just regex matches.
Tests for Instruction should should not depend on the compiler output; create the bytecode directly.


This is not a new problem, but it does seem to be getting progressively worse.

A lot of the irritation stems from
https://github.com/python/cpython/commit/b39fd0c9b8dc6683924205265ff43cc597d1dfb9
although the tests from before that still hardcode offsets.
History
Date User Action Args
2022-02-15 14:17:08Mark.Shannonsetrecipients: + Mark.Shannon
2022-02-15 14:17:08Mark.Shannonsetmessageid: <1644934628.87.0.437399260946.issue46760@roundup.psfhosted.org>
2022-02-15 14:17:08Mark.Shannonlinkissue46760 messages
2022-02-15 14:17:08Mark.Shannoncreate