This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eryksun
Recipients eryksun, jeremy.kloth, jkloth, vstinner
Date 2022-02-14.09:27:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1644830838.55.0.519098782831.issue46716@roundup.psfhosted.org>
In-reply-to
Content
> I fear the potential 3rd-party breakage alone should bump
> this to its own issue.

The change to the DWORD converter in _winapi should only be in 3.11+. If this causes problems for other projects, they're probably depending on undefined behavior in the standard library. No third-party package or application should use _winapi directly.

> 1) modify Windows Popen._wait() to raise on out of bounds 
> values [< 0 or >= INFINITE]

I think raising ValueError would be best at this level. For example:

            if timeout is None:
                timeout_millis = _winapi.INFINITE
            else:
                timeout_millis = int(timeout * 1000)
                if timeout_millis >= _winapi.INFINITE:
                    raise ValueError("'timeout' exceeds the platform limit")
                if timeout_millis < 0:
                    raise ValueError("'timeout' must be non-negative")
History
Date User Action Args
2022-02-14 09:27:18eryksunsetrecipients: + eryksun, vstinner, jkloth, jeremy.kloth
2022-02-14 09:27:18eryksunsetmessageid: <1644830838.55.0.519098782831.issue46716@roundup.psfhosted.org>
2022-02-14 09:27:18eryksunlinkissue46716 messages
2022-02-14 09:27:18eryksuncreate