Message 412323 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	corona10, erlendaasland, giovanniwijaya, gvanrossum, lukasz.langa, orsenthil, shihai1991, terry.reedy, vstinner
Date	2022-02-02.01:31:33
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1643765493.62.0.913885409591.issue44359@roundup.psfhosted.org>
In-reply-to

Content
GH-31069 simply silently ignore all socket errors. I tried to write a smart fix which only ignores socket errors when tests are done, in tearDown(). But than I got issues in makepasv() tests which creates a socket and immediately closes it. The server also logs an error in this case. IMO it's not worth it trying to write the perfect error handling for test_ftplib.

GH-31069 simply silently ignore all socket errors.

I tried to write a smart fix which only ignores socket errors when tests are done, in tearDown(). But than I got issues in makepasv() tests which creates a socket and immediately closes it. The server also logs an error in this case.

IMO it's not worth it trying to write the perfect error handling for test_ftplib.

History
Date	User	Action	Args
2022-02-02 01:31:33	vstinner	set	recipients: + vstinner, gvanrossum, terry.reedy, orsenthil, lukasz.langa, corona10, shihai1991, erlendaasland, giovanniwijaya
2022-02-02 01:31:33	vstinner	set	messageid: <1643765493.62.0.913885409591.issue44359@roundup.psfhosted.org>
2022-02-02 01:31:33	vstinner	link	issue44359 messages
2022-02-02 01:31:33	vstinner	create