Author rhettinger
Recipients aganders3, aviramha, bar.harel, benjamin.peterson, brandtbucher, bukzor, georg.brandl, levkivskyi, methane, miss-islington, pitrou, rhettinger, serhiy.storchaka
Date 2022-01-15.07:32:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1642231937.64.0.951543035928.issue46376@roundup.psfhosted.org>
In-reply-to
Content
Here's question to focus on:  In what circumstances should a developer ever prefer PyMapping_Check() over PyType_HasFeature() with Py_TPFLAGS_MAPPING?

The latter doesn't give any new, useful information:

   return o && Py_TYPE(o)->tp_as_mapping &&
               Py_TYPE(o)->tp_as_mapping->mp_subscript;

I don't see any reason to build on top of this. It's best to just let it go gently into the good night without disrupting anything that currently happens to work.
History
Date User Action Args
2022-01-15 07:32:17rhettingersetrecipients: + rhettinger, georg.brandl, pitrou, benjamin.peterson, methane, bukzor, aganders3, serhiy.storchaka, levkivskyi, bar.harel, miss-islington, brandtbucher, aviramha
2022-01-15 07:32:17rhettingersetmessageid: <1642231937.64.0.951543035928.issue46376@roundup.psfhosted.org>
2022-01-15 07:32:17rhettingerlinkissue46376 messages
2022-01-15 07:32:17rhettingercreate