This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author larry
Recipients Zooko.Wilcox-O'Hearn, christian.heimes, corona10, jstasiak, kmaork, larry, mgorny, oconnor663, xtreak
Date 2022-01-13.02:20:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1642040415.78.0.533983231075.issue39298@roundup.psfhosted.org>
In-reply-to
Content
> In setup.py I assume that the target platform of the build is the same as the current interpreter's platform.

If this is included in CPython, it won't be using setup.py, so this isn't a concern.

I don't think there's a way to use setup.py to cross-compile, so I'm not sure this ever was a concern.


> - Compiling assembly files.

AFAICT Python currently ships exactly one assembly file, "Modules/_decimal/libmpdec/vcdiv64.asm", which is only built on Windows.  It would be a brave new world of configure.ac hacking to build assembly language files on POSIX platforms.  As a first pass I say we merge the reference C implementation.  Maybe someday we could add the SIMD assembly language stuff--or use the one built in to OpenSSL (if they ever add BLAKE3).

> I assume we don't want to check in the .obj files?

Correct, we don't.

> - blake3module.c contains an awful lot of gotos to handle allocation failure cases.

Works for me, please keep it.
History
Date User Action Args
2022-01-13 02:20:15larrysetrecipients: + larry, christian.heimes, mgorny, Zooko.Wilcox-O'Hearn, jstasiak, oconnor663, corona10, xtreak, kmaork
2022-01-13 02:20:15larrysetmessageid: <1642040415.78.0.533983231075.issue39298@roundup.psfhosted.org>
2022-01-13 02:20:15larrylinkissue39298 messages
2022-01-13 02:20:15larrycreate