Message410397
@Andreas
First of all, thanks for addressing my questions on the PR. I have one more question which I'll post here since it's not entirely related to your PR.
ForwardRef isn't meant to be explicitly instantiated by a user [1] (it's a typing internal class), so do you mind sharing what your current use case is please? My concern here is that exposing things in __repr__ would force us to keep `module` forever (I'm 100% fine with __eq__ and __hash__). After digging up the commit history, I now recall that the module parameter was used solely as a fix for ForwardRefs in different-module TypedDict (see GH-27017 or bpo-41249). It's not used anywhere else, so I don't know if your current use case was ever intended when the module parameter was added.
[1]: https://docs.python.org/3/library/typing.html#typing.ForwardRef |
|
Date |
User |
Action |
Args |
2022-01-12 14:04:25 | kj | set | recipients:
+ kj, gvanrossum, python-dev, kumaraditya, AlexWaygood, andreash |
2022-01-12 14:04:25 | kj | set | messageid: <1641996265.15.0.00867139545282.issue46333@roundup.psfhosted.org> |
2022-01-12 14:04:25 | kj | link | issue46333 messages |
2022-01-12 14:04:24 | kj | create | |
|