Message 408488 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	andrei.avk
Recipients	andrei.avk
Date	2021-12-13.22:45:11
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1639435512.0.0.159079727605.issue46068@roundup.psfhosted.org>
In-reply-to

Content
In discussion on https://github.com/python/cpython/pull/29910 related to whether to use warnings.warn or logging.warning, I found two places in the library where it might make sense to change to logging.warning. There's probably other instances where the same change can be made but it's not easy to tell just by going through the list because the difference of when use one or the other is not always clearcut. If more instances are found, they can be added to this issue. https://docs.python.org/3/howto/logging.html#when-to-use-logging https://github.com/python/cpython/blob/eb483c46d62707bdf705491f76cf1fa9642fb47e/Lib/zoneinfo/_tzpath.py#L44 https://github.com/python/cpython/blob/f42a06ba279c916fb67289e47f9bc60dc5dee4ee/Lib/zipfile.py#L1480 The downside of making this change is that it may break 3rd party unit tests.

In discussion on https://github.com/python/cpython/pull/29910 related to whether to use warnings.warn or logging.warning, I found two places in the library where it might make sense to change to logging.warning. There's probably other instances where the same change can be made but it's not easy to tell just by going through the list because the difference of when use one or the other is not always clearcut. If more instances are found, they can be added to this issue.

https://docs.python.org/3/howto/logging.html#when-to-use-logging

https://github.com/python/cpython/blob/eb483c46d62707bdf705491f76cf1fa9642fb47e/Lib/zoneinfo/_tzpath.py#L44

https://github.com/python/cpython/blob/f42a06ba279c916fb67289e47f9bc60dc5dee4ee/Lib/zipfile.py#L1480

The downside of making this change is that it may break 3rd party unit tests.

History
Date	User	Action	Args
2021-12-13 22:45:12	andrei.avk	set	recipients: + andrei.avk
2021-12-13 22:45:11	andrei.avk	set	messageid: <1639435512.0.0.159079727605.issue46068@roundup.psfhosted.org>
2021-12-13 22:45:11	andrei.avk	link	issue46068 messages
2021-12-13 22:45:11	andrei.avk	create