Message407684
> Is there any measurable performance benefit from this?
I wouldn't expect any performance changes either way. If it worked out to be slower, that would an unpleasant surprise and a good reason to reject this change. If it worked out to be faster, well, that would be great!
> Reducing several hundred thousand lines of code by 148 is not a compelling benefit :)
But it's not just any old 148 lines. By my count it includes the removal of 47 `break` statements. For a change of this nature there's certainly a chance of introducing errors. On the other hand, every one of those `break` statements is a site of manual loop-handling logic, and those already present some risk of introducing errors. |
|
Date |
User |
Action |
Args |
2021-12-04 20:22:08 | nickdrozd | set | recipients:
+ nickdrozd, rhettinger, zach.ware, iritkatriel |
2021-12-04 20:22:08 | nickdrozd | set | messageid: <1638649328.86.0.503829722143.issue45975@roundup.psfhosted.org> |
2021-12-04 20:22:08 | nickdrozd | link | issue45975 messages |
2021-12-04 20:22:08 | nickdrozd | create | |
|