This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author neonene
Recipients Mark.Shannon, brandtbucher, erlendaasland, gvanrossum, kj, lemburg, malin, neonene, pablogsal, paul.moore, rhettinger, steve.dower, tim.golden, vstinner, zach.ware
Date 2021-11-28.05:03:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1638075789.66.0.880757511612.issue45116@roundup.psfhosted.org>
In-reply-to
Content
I requested the MSVC team to reconsider the inlining issues, including __forceinline.
https://developercommunity.visualstudio.com/t/1595341


The stuck at link due to __forceinline can be avoided by completing the _Py_DECREF optimization outside _PyEval_EvalFrameDefault:

    static inline void         // no __forceinline
    _Py_DECREF_impl(...) {
        ...
    }
    static __forceinline void
    _Py_DECREF(...) {          // no conditional branch in the function
        _Py_DECREF_impl(...);    
    }


In _PyEval_EvalFrameDefault, wrapping the callees like above seems better for performance than just specifying __forceinline under the current MSVC.
History
Date User Action Args
2021-11-28 05:03:09neonenesetrecipients: + neonene, lemburg, gvanrossum, rhettinger, paul.moore, vstinner, tim.golden, Mark.Shannon, zach.ware, steve.dower, malin, pablogsal, brandtbucher, erlendaasland, kj
2021-11-28 05:03:09neonenesetmessageid: <1638075789.66.0.880757511612.issue45116@roundup.psfhosted.org>
2021-11-28 05:03:09neonenelinkissue45116 messages
2021-11-28 05:03:09neonenecreate