Message40695
Logged In: YES
user_id=6656
Thanks for the comments, Neal!
I'm not sure it's possible to separate the changes in the
way you describe. For instance, com_addoparg ->
com_set_lineno stops SET_LINENO being generated, so breaks
tracing without the VM changes, but the VM changes make
SET_LINENO into an unknown opcode...
I didn't intend to upload the pystone change.
About the comments:
- the last little RETURN_NONE changes are easy. Thanks for
the pointer.
- agree there are too many bits of code grovelling
co_lnotab. however, it's not clear that they can easily be
refactored. maybe a generator would be useful... hmm. let
me think about this one.
- did I take out the initialisation of frame.f_lineno
entirely? oops. probably set it to co_firstlineno.
- fixed trace.py docstring. reusing code not all that
easy, because different uses have subtly different requirements.
hmm, inspect.getlineno is now pointless...
was there any particular reason you unassigned the patch?
Just curious as the main reason it was assigned to Guido was
to make sure he saw it. |
|
Date |
User |
Action |
Args |
2007-08-23 15:14:19 | admin | link | issue587993 messages |
2007-08-23 15:14:19 | admin | create | |
|