This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nnorwitz
Recipients
Date 2002-08-03.20:06:27
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=33168

Overall, the patch looks very good.

It would be nice to check in some of the changes separate
from this patch:
 * com_addoparg(SET_LINENO) -> com_set_lineno()
 * the updated comments and whitespace
 * pystone
 * dis.py, disassemble(), perhaps
 * RETURN_NONE, perhaps

Here's other minor comments:
 * Need to add RETURN_NONE opcode into dis.py
 * Need to add doc for RETURN_NONE in libdis.tex
 * It would be nice if the code from inspect.getlineno could
be reused in disassemble()
   (not sure this can be done, though--i saw at least 4
variations of this code, 2 in python and 2 in C)
 * Should frame.f_lineno be initialized to 0, -1 or
something invalid?
 * scripts/trace.py reimplements getting the lineno, why not
reuse code?
 * docstring in scripts/trace._find_LINENO_from_code needs
to remove ref to SET_LINENO

History
Date User Action Args
2007-08-23 15:14:19adminlinkissue587993 messages
2007-08-23 15:14:19admincreate