Message406181
In general this sounds reasonable; - but a couple of thoughts / comments:
- If you have a dict with mixed numbers in str format and in number format (i.e. ints as numbers and ints as strings in your case), you are creating problems in many potential places. The core of the problem is logically inconsistent keys rather than the step of conversion to JSON. So the most useful place for warning would be when adding a new key, but that wouldn't be practical.
- Even if something is to be done at conversion to JSON, it's not clear if it should be a warning (would that be enough when the conversion is a logical bug?), or it should be some kind of strict=True mode that raises a ValueError? |
|
Date |
User |
Action |
Args |
2021-11-12 00:14:55 | andrei.avk | set | recipients:
+ andrei.avk, bob.ippolito, corona10, Zeturic |
2021-11-12 00:14:55 | andrei.avk | set | messageid: <1636676095.16.0.839917691625.issue45054@roundup.psfhosted.org> |
2021-11-12 00:14:55 | andrei.avk | link | issue45054 messages |
2021-11-12 00:14:54 | andrei.avk | create | |
|