Message405025
> Alternatively, can't we just os.chdir(self._old_cwd) in __enter__ and preemptively fail?
If the context manager isn't going to address the long-path case reliably using either a file-descriptor approach or repeated relative chdir() calls, then I think failing early like this is the next best choice.
The previous directory getting deleted is a random environment error, which can be left up to the caller. In POSIX, it might be avoidable using a file-descriptor approach, but POSIX doesn't actually guarantee that fchdir() will succeed if the file descriptor refers to a deleted directory. |
|
Date |
User |
Action |
Args |
2021-10-26 05:37:29 | eryksun | set | recipients:
+ eryksun, barry, FFY00, ucodery |
2021-10-26 05:37:29 | eryksun | set | messageid: <1635226649.21.0.321508781.issue45545@roundup.psfhosted.org> |
2021-10-26 05:37:29 | eryksun | link | issue45545 messages |
2021-10-26 05:37:29 | eryksun | create | |
|