➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Mark.Shannon, chris.jerdonek, corona10, gvanrossum, iritkatriel, lukasz.langa, miss-islington, pablogsal, vstinner
Date 2021-09-01.15:06:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1630508763.63.0.803154384827.issue44895@roundup.psfhosted.org>
In-reply-to
Content 
>  I changed dash_R_cleanup to put the sys._clear_type_cache() after clear_caches() and the leak is gone

Aha! The order of function calls in dash_R_cleanup() matters.

Calling sys._clear_type_cache() at the end of dash_R_cleanup() perfectly makes sense. If you do that, please add a comment to explain that the order matters. For example, the code about ABC classes is likely to modify classes.

About the gc_collect() call, I dislike calling it in clear_caches() and then again in dash_R_cleanup(). I would even prefer to *remove* it from both functions and call it explicitly at the call site: in dash_R() and in runtest.py.
History
Date User Action Args
2021-09-01 15:06:03vstinnersetrecipients: + vstinner, gvanrossum, chris.jerdonek, lukasz.langa, Mark.Shannon, corona10, pablogsal, miss-islington, iritkatriel
2021-09-01 15:06:03vstinnersetmessageid: <1630508763.63.0.803154384827.issue44895@roundup.psfhosted.org>
2021-09-01 15:06:03vstinnerlinkissue44895 messages
2021-09-01 15:06:03vstinnercreate