Author pablogsal
Recipients BTaskaya, ammar2, gvanrossum, lys.nikolaou, pablogsal
Date 2021-08-11.15:13:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1628694790.75.0.854809187579.issue44885@roundup.psfhosted.org>
In-reply-to
Content
Actually, this has even more problems. Because we are using strstr to find the start of the expression in the parent string, if the expression is repeated the offsets are incorrectly generated:

For example:

print(f"Here is that {xxx} pesky {xxx} again")

This produces:

...
                     FormattedValue(
                        value=Name(
                           id='xxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=22,
                           end_lineno=1,
                           end_col_offset=25),
...
                     FormattedValue(
                        value=Name(
                           id='xxxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=22,
                           end_lineno=1,
                           end_col_offset=25),
...

while

print(f"Here is that {xxx} pesky {xxxx} again")

(different variables) produces:

...
                     FormattedValue(
                        value=Name(
                           id='xxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=22,
                           end_lineno=1,
                           end_col_offset=25),
...
                     FormattedValue(
                        value=Name(
                           id='xxxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=34,
                           end_lineno=1,
                           end_col_offset=38),
...
History
Date User Action Args
2021-08-11 15:13:10pablogsalsetrecipients: + pablogsal, gvanrossum, ammar2, lys.nikolaou, BTaskaya
2021-08-11 15:13:10pablogsalsetmessageid: <1628694790.75.0.854809187579.issue44885@roundup.psfhosted.org>
2021-08-11 15:13:10pablogsallinkissue44885 messages
2021-08-11 15:13:10pablogsalcreate