Author lukasz.langa
Recipients lukasz.langa, mark.dickinson, serhiy.storchaka, thatiparthy
Date 2021-07-23.14:43:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1627051425.69.0.901408022823.issue44707@roundup.psfhosted.org>
In-reply-to
Content
I'm still unable to reproduce this locally. Objects/listobject.c:527:24 is this line in `list_concat`:

    dest = np->ob_item + Py_SIZE(a);

(permalink: https://github.com/python/cpython/blob/8f42106b5c362495f72c6ca2fa3884538e4023db/Objects/listobject.c#L527)

This can only be problematic if `ob_item` of the new list is NULL *AND* list `a` is non-empty. In practice that's impossible because if `a` is non-empty, it would already populate `np` with its elements using the for-loop right above the line in question.

So this sounds like the compiler complaining about NULL + 0 which seems unnecessary?

By the way, instead of messing with CC, it's preferred to use the --with-undefined-behavior-sanitizer option to ./configure.

We could accept Serhiy's change but I'm afraid that without a reliable way to reproduce, this will regress at some point.
History
Date User Action Args
2021-07-23 14:43:45lukasz.langasetrecipients: + lukasz.langa, mark.dickinson, serhiy.storchaka, thatiparthy
2021-07-23 14:43:45lukasz.langasetmessageid: <1627051425.69.0.901408022823.issue44707@roundup.psfhosted.org>
2021-07-23 14:43:45lukasz.langalinkissue44707 messages
2021-07-23 14:43:45lukasz.langacreate