Author steve.dower
Recipients christian.heimes, pablogsal, steve.dower, vstinner
Date 2021-05-25.22:44:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1621982687.85.0.655027204452.issue43921@roundup.psfhosted.org>
In-reply-to
Content
> But 3.9 and 3.8 are not failing on test_ssl, so do something has clearly changed. Are the failing tests new?

They're flakey in the sense that they're not failing reliably, when they clearly should be :)

If something changed about how any part of the response is written into the buffer, it could change when the OS decides to dispatch it and unblock the receiving thread, which is going to affect the state observed by the test at the time it observes it (and as we already know, there are inherent race conditions that sometimes recognise the close of the connection before it's finished reading). These are difficult tests to write, because there are so many weird interactions like this.

In terms of this actual change, my best guess is that one of the removed checks actually mattered on Windows, probably because of a different compile flag. We just use the defaults as generated by their Perl scripts, and I'd hope that there'd be compile errors if anything too blatant was changed (I don't see anything obvious looking through 39258d3595300bc7b952854c915f63ae2d4b9c3e). But short of that, I don't see anything deterministic changed here.
History
Date User Action Args
2021-05-25 22:44:47steve.dowersetrecipients: + steve.dower, vstinner, christian.heimes, pablogsal
2021-05-25 22:44:47steve.dowersetmessageid: <1621982687.85.0.655027204452.issue43921@roundup.psfhosted.org>
2021-05-25 22:44:47steve.dowerlinkissue43921 messages
2021-05-25 22:44:47steve.dowercreate