Message 392614 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	gregory.p.smith
Date	2021-05-01.18:17:15
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1619893035.74.0.250033562413.issue44002@roundup.psfhosted.org>
In-reply-to

Content
`urllib.parse` has custom caching code for both `urlsplit()` and `quote()`. From 1996. https://github.com/python/cpython/commit/3fd32ecd9232fcb041b9f1f7a19a1e7e65cf11a0 https://github.com/python/cpython/commit/74495409861b357d9925937d6576229c74e2550d with a truthful comment added by Nick in 2010 that we should just use functools.lru_cache. https://github.com/python/cpython/commit/9fc443cf590c76d4b979c46dc954d3956cee0319#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e time to clean up this cruft and do that. I'm waiting for after the 3.10 cut and a still in progress urllib.parse security fix to land before rebasing my soon to be attached PR to avoid code conflicts.

`urllib.parse` has custom caching code for both `urlsplit()` and `quote()`.  From 1996.

https://github.com/python/cpython/commit/3fd32ecd9232fcb041b9f1f7a19a1e7e65cf11a0
https://github.com/python/cpython/commit/74495409861b357d9925937d6576229c74e2550d

with a truthful comment added by Nick in 2010 that we should just use functools.lru_cache.

https://github.com/python/cpython/commit/9fc443cf590c76d4b979c46dc954d3956cee0319#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e

time to clean up this cruft and do that.

I'm waiting for after the 3.10 cut and a still in progress urllib.parse security fix to land before rebasing my soon to be attached PR to avoid code conflicts.

History
Date	User	Action	Args
2021-05-01 18:17:15	gregory.p.smith	set	recipients: + gregory.p.smith
2021-05-01 18:17:15	gregory.p.smith	set	messageid: <1619893035.74.0.250033562413.issue44002@roundup.psfhosted.org>
2021-05-01 18:17:15	gregory.p.smith	link	issue44002 messages
2021-05-01 18:17:15	gregory.p.smith	create