Message 392291 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	erlendaasland
Recipients	erlendaasland, gvanrossum, pitrou, vstinner
Date	2021-04-29.08:35:18
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1619685319.39.0.839354323973.issue43973@roundup.psfhosted.org>
In-reply-to

Content
IMO, we can drop most (all?) of the huge comment before the check in object_set_class(). History is preserved in the git log. Contrary to Py_TPFLAGS_HEAPTYPE, using Py_TPFLAGS_IMMUTABLETYPE speaks for itself. We might reduce it to just refer to to bpo-43908 and bpo-24912. Something a la this: /* Historically, only static types were immutable. * Py_TPFLAGS_IMMUTABLETYPE was introduced in Python 3.10. * See bpo-43908 and bpo-24912. */ What do you think?

IMO, we can drop most (all?) of the huge comment before the check in object_set_class(). History is preserved in the git log. Contrary to Py_TPFLAGS_HEAPTYPE, using Py_TPFLAGS_IMMUTABLETYPE speaks for itself. We might reduce it to just refer to to bpo-43908 and bpo-24912.

Something a la this:
/* Historically, only static types were immutable.
 * Py_TPFLAGS_IMMUTABLETYPE was introduced in Python 3.10.
 * See bpo-43908 and bpo-24912. */

What do you think?

History
Date	User	Action	Args
2021-04-29 08:35:19	erlendaasland	set	recipients: + erlendaasland, gvanrossum, pitrou, vstinner
2021-04-29 08:35:19	erlendaasland	set	messageid: <1619685319.39.0.839354323973.issue43973@roundup.psfhosted.org>
2021-04-29 08:35:19	erlendaasland	link	issue43973 messages
2021-04-29 08:35:18	erlendaasland	create