This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author DaRoee
Recipients DaRoee, ncoghlan, pitrou, rhettinger, vinay.sajip
Date 2021-04-27.20:17:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1619554620.79.0.973091396127.issue43939@roundup.psfhosted.org>
In-reply-to
Content
Ha! Already gave them my analysis, and stopped using that package since.
While I certainly think this is not the trivial, basic usage, and that the pattern used for the lock is common (and part of some PEP if I remember correctly), I'm kind of puzzled on that fact that context manager solves it. 
The test will pass constantly once the change is made (even though it looks like RLock __enter__ is just calling the acquire function), and I overall think this is a good change to do in the Handler class, even it's just for self.lock (can we find and understand why the last proposal was rejected?).

I'll submit a PR in a few days, but was wondering on the usage of the lock, and that it doesn't always exists on `self`. Anyway, I assume these are questions that we can continue discussing in the PR if you also think this is a good direction..
History
Date User Action Args
2021-04-27 20:17:00DaRoeesetrecipients: + DaRoee, rhettinger, vinay.sajip, ncoghlan, pitrou
2021-04-27 20:17:00DaRoeesetmessageid: <1619554620.79.0.973091396127.issue43939@roundup.psfhosted.org>
2021-04-27 20:17:00DaRoeelinkissue43939 messages
2021-04-27 20:17:00DaRoeecreate