Message392066
Please don't lose the big picture here.
Previously, the reported line number was *somewhere close* to the currently executing code. That's typically all I need from a traceback: the fix for a bug often needs to go a few lines above/below where it's reported.
If, in an effort to make line numbers *exact*, we determine that there's no good line number to report and use -1 or None, we're introducing a regression.
> We could give it the line number of the `with` keyword, but that might break coverage and profiling tools.
That sounds like a reasonable idea, despite the drawback. As we can see from the report, *any* change will probably break *some* tools. |
|
Date |
User |
Action |
Args |
2021-04-27 12:53:47 | petr.viktorin | set | recipients:
+ petr.viktorin, gvanrossum, nedbat, Mark.Shannon, Anthony Sottile, pablogsal |
2021-04-27 12:53:47 | petr.viktorin | set | messageid: <1619528027.61.0.752124751708.issue43933@roundup.psfhosted.org> |
2021-04-27 12:53:47 | petr.viktorin | link | issue43933 messages |
2021-04-27 12:53:47 | petr.viktorin | create | |
|