Author gvanrossum
Recipients Mark.Shannon, christian.heimes, corona10, erlendaasland, gvanrossum, pablogsal, serhiy.storchaka, shihai1991, shreyanavigyan, vstinner
Date 2021-04-26.17:24:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1619457885.13.0.956248349585.issue43908@roundup.psfhosted.org>
In-reply-to
Content
> > Could you please land the new flag and typeobject.c code now?
>
> I've only got two more questions before I mark it ready for review,
> and that's regarding Guido's comment in msg391756:
> Should the new flag also take care of __class__ assignment,
> or should we leave that out?

Let's leave that out.
It's a separate can of worms and someone else can  look into it later.

> Are there other places where !Py_TPFLAGS_HEAPTYPE is used
> where we would like to use the immutable flag?

Again, I think we can do that later.

So I am in favor of landing your (small) patch that introduces the flag now.

I also think you should try to separately land small patches that add the IMMUTABLETYPE flag to a few very public types, e.g. array.array and the three in _sre (which are exported by re.py).

We can then look into the test failures with a little less time pressure.
History
Date User Action Args
2021-04-26 17:24:45gvanrossumsetrecipients: + gvanrossum, vstinner, christian.heimes, Mark.Shannon, serhiy.storchaka, corona10, pablogsal, shihai1991, erlendaasland, shreyanavigyan
2021-04-26 17:24:45gvanrossumsetmessageid: <1619457885.13.0.956248349585.issue43908@roundup.psfhosted.org>
2021-04-26 17:24:45gvanrossumlinkissue43908 messages
2021-04-26 17:24:45gvanrossumcreate