Message391740
Left some minor suggestions on the PR, but wanted to copy this comment here as well:
I wonder if it's worth returning the connection object when it's created (through a new event in module.c) and then reference it in these events? That can then correlate these (and other) events with the file - we do this already for sockets.
After some thought, I think it's probably not worth it for these ones. The important information is in the extension being loaded, and it doesn't really relate to the connection at all. However, if we wanted to add it later, we couldn't. So might be worth doing now? |
|
Date |
User |
Action |
Args |
2021-04-23 21:36:33 | steve.dower | set | recipients:
+ steve.dower, christian.heimes, berker.peksag, erlendaasland |
2021-04-23 21:36:33 | steve.dower | set | messageid: <1619213793.19.0.568479363478.issue43762@roundup.psfhosted.org> |
2021-04-23 21:36:33 | steve.dower | link | issue43762 messages |
2021-04-23 21:36:33 | steve.dower | create | |
|