Message 391600 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	Mark.Shannon, corona10, erlendaasland, gvanrossum, serhiy.storchaka, shihai1991, vstinner
Date	2021-04-22.13:34:12
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1619098452.16.0.453539136743.issue43908@roundup.psfhosted.org>
In-reply-to

Content
> Maybe name it Py_TPFLAGS_IMMUTABLETYPE? "TPFLAGS" stands for "type flags". So IMO adding "TYPE" suffix is redundant. If tomorrow, we want to add a flag for immutable instance, we can add a new Py_TPFLAGS_IMMUTABLE_INSTANCE flag. On the other side, TYPE suffix is consistent with other flags :-) /* Set if the type object is dynamically allocated / #define Py_TPFLAGS_HEAPTYPE (1UL << 9) / Set if the type allows subclassing */ #define Py_TPFLAGS_BASETYPE (1UL << 10)

> Maybe name it Py_TPFLAGS_IMMUTABLETYPE?

"TPFLAGS" stands for "type flags". So IMO adding "TYPE" suffix is redundant. If tomorrow, we want to add a flag for immutable instance, we can add a new Py_TPFLAGS_IMMUTABLE_INSTANCE flag.

On the other side, TYPE suffix is consistent with other flags :-)

/* Set if the type object is dynamically allocated */
#define Py_TPFLAGS_HEAPTYPE (1UL << 9)

/* Set if the type allows subclassing */
#define Py_TPFLAGS_BASETYPE (1UL << 10)

History
Date	User	Action	Args
2021-04-22 13:34:12	vstinner	set	recipients: + vstinner, gvanrossum, Mark.Shannon, serhiy.storchaka, corona10, shihai1991, erlendaasland
2021-04-22 13:34:12	vstinner	set	messageid: <1619098452.16.0.453539136743.issue43908@roundup.psfhosted.org>
2021-04-22 13:34:12	vstinner	link	issue43908 messages
2021-04-22 13:34:12	vstinner	create