Message 389682 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pablogsal
Recipients	christian.heimes, gregory.p.smith, miss-islington, pablogsal, vstinner
Date	2021-03-29.10:28:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1617013687.56.0.0307102899661.issue40645@roundup.psfhosted.org>
In-reply-to

Content
Seems that commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 introduced some reference leaks: commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 Author: Christian Heimes <christian@python.org> Date: Sat Mar 27 14:55:03 2021 +0100 bpo-40645: use C implementation of HMAC (GH-24920) 𓋹 ./python.exe -m test test_hashlib -R 3:3 0:00:00 load avg: 5.67 Run tests sequentially 0:00:00 load avg: 5.67 [1/1] test_hashlib beginning 6 repetitions 123456 ...... test_hashlib leaked [1, 1, 1] references, sum=3 test_hashlib failed == Tests result: FAILURE == 1 test failed: test_hashlib Total duration: 8.7 sec Tests result: FAILURE - [x] fix tests - [ ] add test scenarios for old/new code. Signed-off-by: Christian Heimes <christian@python.org> Lib/hashlib.py \| 1 + Lib/hmac.py \| 86 +++++++----- Lib/test/test_hmac.py \| 114 +++++++++------- .../2021-03-19-10-22-17.bpo-40645.5pXhb-.rst \| 2 + Modules/_hashopenssl.c \| 150 +++++++++++++++++++-- Modules/clinic/_hashopenssl.c.h \| 38 +----- 6 files changed, 267 insertions(+), 124 deletions(-) create mode 100644 bpo-40645.5pXhb-.rst">Misc/NEWS.d/next/Library/2021-03-19-10-22-17.bpo-40645.5pXhb-.rst

Seems that commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 introduced some reference leaks:


commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631
Author: Christian Heimes <christian@python.org>
Date:   Sat Mar 27 14:55:03 2021 +0100

    bpo-40645: use C implementation of HMAC (GH-24920)



𓋹 ./python.exe -m test test_hashlib -R 3:3
0:00:00 load avg: 5.67 Run tests sequentially
0:00:00 load avg: 5.67 [1/1] test_hashlib
beginning 6 repetitions
123456
......
test_hashlib leaked [1, 1, 1] references, sum=3
test_hashlib failed

== Tests result: FAILURE ==

1 test failed:
    test_hashlib

Total duration: 8.7 sec
Tests result: FAILURE


    - [x] fix tests
    - [ ] add test scenarios for old/new code.

    Signed-off-by: Christian Heimes <christian@python.org>

 Lib/hashlib.py                                     |   1 +
 Lib/hmac.py                                        |  86 +++++++-----
 Lib/test/test_hmac.py                              | 114 +++++++++-------
 .../2021-03-19-10-22-17.bpo-40645.5pXhb-.rst       |   2 +
 Modules/_hashopenssl.c                             | 150 +++++++++++++++++++--
 Modules/clinic/_hashopenssl.c.h                    |  38 +-----
 6 files changed, 267 insertions(+), 124 deletions(-)
 create mode 100644 bpo-40645.5pXhb-.rst">Misc/NEWS.d/next/Library/2021-03-19-10-22-17.bpo-40645.5pXhb-.rst

History
Date	User	Action	Args
2021-03-29 10:28:07	pablogsal	set	recipients: + pablogsal, gregory.p.smith, vstinner, christian.heimes, miss-islington
2021-03-29 10:28:07	pablogsal	set	messageid: <1617013687.56.0.0307102899661.issue40645@roundup.psfhosted.org>
2021-03-29 10:28:07	pablogsal	link	issue40645 messages
2021-03-29 10:28:06	pablogsal	create