Message38917
Logged In: YES
user_id=205865
- I agree about the comments. I'll make them reasonable.
- one underscore is fine
- I intended to have a patch that works with python 1.5, but
then again the module itself doesn't run with 1.5 anyway, so
good point.
- When you make a connection to a server through a proxy,
you have to connect to the proxy, but everything else should
be the same, i.e. the Host: field has to refer to the server
and so on. I wanted to reuse the code from _set_hostport,
which saves the host and port in self.host, self.port. Had
to do it twice, once for the proxy hostname, once for the
server's. _set_hostport takes care of the default port and
of the "hostname:port" syntax, which is convenient.
I'll put together a patched patch and upload it.
|
|
Date |
User |
Action |
Args |
2007-08-23 15:10:56 | admin | link | issue515003 messages |
2007-08-23 15:10:56 | admin | create | |
|