Message38916
Logged In: YES
user_id=31392
The proposed classes seem useful enough, but I would like to
make several suggestions for the implementation.
- There are too many comments. Comments should only be
added when
the intent of the code needs to be explained. We
definitely don't need
one comment for each line of code. The comment in the
HTTPS proxy
putrequest() is an example of a helpful comment.
- Just use a single underscore for private variables.
- Please use string methods instead of the string module.
- I don't understand the logic of switching the host/port
back and forth.
|
|
Date |
User |
Action |
Args |
2007-08-23 15:10:56 | admin | link | issue515003 messages |
2007-08-23 15:10:56 | admin | create | |
|