Message 387221 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	erlendaasland
Recipients	berker.peksag, erlendaasland, serhiy.storchaka
Date	2021-02-18.11:29:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1613647782.75.0.100419988551.issue43249@roundup.psfhosted.org>
In-reply-to

Content
> Sounds good to me but I'd say designing APIs relying on call order is bad too :) Yes, it's too easy to mess up things with this part of the SQLite API :) I'll throw up a PR. BTW (small digression): I really want to refactor _pysqlite_fetch_one_row() so it uses two helpers (for example _fetch_nth_column_with_converter() and _fetch_nth_column()). It will be easier to maintain, and it's way easier to read. The coverage for this function is close to 100%, so it should be pretty safe to refactor it.

> Sounds good to me but I'd say designing APIs relying on call order is bad too :)

Yes, it's too easy to mess up things with this part of the SQLite API :) I'll throw up a PR.


BTW (small digression):
I really want to refactor _pysqlite_fetch_one_row() so it uses two helpers (for example _fetch_nth_column_with_converter() and _fetch_nth_column()). It will be easier to maintain, and it's way easier to read. The coverage for this function is close to 100%, so it should be pretty safe to refactor it.

History
Date	User	Action	Args
2021-02-18 11:29:42	erlendaasland	set	recipients: + erlendaasland, berker.peksag, serhiy.storchaka
2021-02-18 11:29:42	erlendaasland	set	messageid: <1613647782.75.0.100419988551.issue43249@roundup.psfhosted.org>
2021-02-18 11:29:42	erlendaasland	link	issue43249 messages
2021-02-18 11:29:42	erlendaasland	create