Message386490
You're right to think that folding is a problem Steve, but thankfully my PR does not enable COMDAT folding for that very reason :).
/OPT:ICF enables identical COMDAT folding, but surprisingly-to-me /OPT:REF seems to still enable a small amount of folding (I confirmed with the linker dev at Microsoft that this is true). Thus, just /OPT:REF alone caused test failures as there are test cases verifying COMDAT folding didn't occur.
Thus, in my PR I am using /OPT:REF,NOICF to explicitly disable any ICF'ing at all and I see no folding occurring anywhere, and those COMDAT-folding-sensitive tests pass with that flag.
The dumpbin /exports output is identical after this change. |
|
Date |
User |
Action |
Args |
2021-02-04 19:10:36 | Austin-Lamb | set | recipients:
+ Austin-Lamb, terry.reedy, paul.moore, tim.golden, zach.ware, eryksun, steve.dower |
2021-02-04 19:10:36 | Austin-Lamb | set | messageid: <1612465836.69.0.522968024883.issue42825@roundup.psfhosted.org> |
2021-02-04 19:10:36 | Austin-Lamb | link | issue42825 messages |
2021-02-04 19:10:36 | Austin-Lamb | create | |
|