This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Austin-Lamb
Recipients Austin-Lamb, eryksun, paul.moore, steve.dower, terry.reedy, tim.golden, zach.ware
Date 2021-02-04.19:10:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1612465836.69.0.522968024883.issue42825@roundup.psfhosted.org>
In-reply-to
Content
You're right to think that folding is a problem Steve, but thankfully my PR does not enable COMDAT folding for that very reason :).

/OPT:ICF enables identical COMDAT folding, but surprisingly-to-me /OPT:REF seems to still enable a small amount of  folding (I confirmed with the linker dev at Microsoft that this is true).  Thus, just /OPT:REF alone caused test failures as there are test cases verifying COMDAT folding didn't occur.

Thus, in my PR I am using /OPT:REF,NOICF to explicitly disable any ICF'ing at all and I see no folding occurring anywhere, and those COMDAT-folding-sensitive tests pass with that flag.

The dumpbin /exports output is identical after this change.
History
Date User Action Args
2021-02-04 19:10:36Austin-Lambsetrecipients: + Austin-Lamb, terry.reedy, paul.moore, tim.golden, zach.ware, eryksun, steve.dower
2021-02-04 19:10:36Austin-Lambsetmessageid: <1612465836.69.0.522968024883.issue42825@roundup.psfhosted.org>
2021-02-04 19:10:36Austin-Lamblinkissue42825 messages
2021-02-04 19:10:36Austin-Lambcreate