Message 385669 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	eryksun
Recipients	eryksun, jkloth, paul.moore, steve.dower, tim.golden, zach.ware
Date	2021-01-25.21:43:14
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1611610994.89.0.927282008765.issue43022@roundup.psfhosted.org>
In-reply-to

Content
> uses a code snippet like this. PathAllocCombine() is Windows 8+, so sample code that uses it would only be for Python 3.9+. I'd prefer the function pointer to be returned as an out parameter, and return an HRESULT status as the result. If LoadLibraryExW() or GetProcAddress() fails, map the error code via HRESULT_FROM_WIN32(GetLastError()). And log to stderr instead of exiting with an error() call.

> uses a code snippet like this.

PathAllocCombine() is Windows 8+, so sample code that uses it would only be for Python 3.9+.

I'd prefer the function pointer to be returned as an out parameter, and return an HRESULT status as the result. If LoadLibraryExW() or GetProcAddress() fails, map the error code via HRESULT_FROM_WIN32(GetLastError()). And log to stderr instead of exiting with an error() call.

History
Date	User	Action	Args
2021-01-25 21:43:14	eryksun	set	recipients: + eryksun, paul.moore, tim.golden, jkloth, zach.ware, steve.dower
2021-01-25 21:43:14	eryksun	set	messageid: <1611610994.89.0.927282008765.issue43022@roundup.psfhosted.org>
2021-01-25 21:43:14	eryksun	link	issue43022 messages
2021-01-25 21:43:14	eryksun	create