➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alanr
Recipients alanr, erlendaasland, jaraco, ned.deily, ronaldoussoren, vinay.sajip, youtux
Date 2021-01-06.17:32:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <6dcf18fe-665e-4ba6-9e6d-79d50d3b9031@www.fastmail.com>
In-reply-to <1609954215.84.0.324277608336.issue38780@roundup.psfhosted.org>
Content 
On Wed, Jan 6, 2021, at 10:30 AM, Vinay Sajip wrote:
> 
> Vinay Sajip <vinay_sajip@yahoo.co.uk> added the comment:
> 
> TBH as I said in the now-closed PR, using a NullSocket seems overkill. 
> As mentioned in msg359594, it seems to make more sense to assign a 
> socket attribute to None early in the constructor. If an error occurs 
> during socket creation, the socket attribute will remain at None. When 
> closing, just ensure the socket attribute isn't None before trying to 
> close it. This mirrors what SocketHandler does.
> 
> ----------
> 
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue38780>
> _______________________________________
>

-- 
  Alan Robertson
  alanr@unix.sh
History
Date User Action Args
2021-01-06 17:32:44alanrsetrecipients: + alanr, vinay.sajip, ronaldoussoren, jaraco, ned.deily, youtux, erlendaasland
2021-01-06 17:32:44alanrlinkissue38780 messages
2021-01-06 17:32:44alanrcreate