Message38439
Logged In: YES
user_id=33168
I'm reviewed most of the updated version. Quick summary:
* strncpy() doesn't null terminate strings, this needs to
be added
* seems to be many leaked references
Here are more details:
* strncpy(dest, str, size) doesn't guarantee the result to
be null terminated,
need dest[size] = '\0'; after all strncpy()s (I see a
bunch in getpath.c)
* getpath.c:get_sys_path_0(), I think some compilers warn
when you do char[i] = 0; (use '\0' instead)
(there may be other places of this)
* import.c:PyImport_InitZip(), have_zlib is an alias to
zlib and isn't really helpful/necessary
* import.c:get_path_type() can leak a reference to pyobj if
it's an int
* import.c:add_directory_names() pylist reference is leaked
* import.c:add_zip_names(), memcmp(path+i, ".zip", 4) is
clearer to me than path[i] == '.' ....
* import.c:add_zip_names, there's a lot of magic #s in this
function
* " " : leak refs when doing PyTuple_SetItem
I think there were other leaked references. I'll try to
spend some more time later. |
|
Date |
User |
Action |
Args |
2007-08-23 15:09:29 | admin | link | issue492105 messages |
2007-08-23 15:09:29 | admin | create | |
|