Message384221
> The getattr call here has a default value, so it should not raise AttributeError. It should also not raise any other exception because a valid implementation of __getattr__ should raise only AttributeError:
but probably the intent of the patch here is to surface a meaningful error with regards to the script, more than an error on the cgitb python lib itself as this is a traceback tool. A bit like an HTML validator which continue to process things to give some kind of meaning.
Diving into previous issues about scanvars
https://bugs.python.org/issue966992
Similar
https://bugs.python.org/issue1047397 The last comment is basically this issue here.
There is a patch which is lot better for this bug and which addresses the issues here.
https://github.com/python/cpython/pull/15094
It has not been merged yet. Not sure why or if there is anything missing.
Probably this bug could be closed as a duplicate of https://bugs.python.org/issue966992
And someone needs to push to push the latest bits for https://github.com/python/cpython/pull/15094
What do you think @iritkatriel ?
I will close my PR. |
|
Date |
User |
Action |
Args |
2021-01-02 13:21:57 | karlcow | set | recipients:
+ karlcow, amc1, ggenellina, arthur.petitpierre, iritkatriel |
2021-01-02 13:21:57 | karlcow | set | messageid: <1609593717.62.0.433147344984.issue4643@roundup.psfhosted.org> |
2021-01-02 13:21:57 | karlcow | link | issue4643 messages |
2021-01-02 13:21:57 | karlcow | create | |
|