Message383938
> Should I restore that optimization in issue37319?
Yes, but to fix the bug it needs to occur earlier in the code (currently line 314):
if stop is None and step is _ONE: <-- Line 314
^^^^^^^^^^^^^^^^^ <-- Add this
And again later:
if istep == 1 and width > 0: <-- Line 348
^-- change to _ONE
As a standalone optimization, it wasn't worth it, but as a way to fix the bug without a regression, it is reasonable. |
|
Date |
User |
Action |
Args |
2020-12-28 23:51:40 | rhettinger | set | recipients:
+ rhettinger, tim.peters, serhiy.storchaka |
2020-12-28 23:51:39 | rhettinger | set | messageid: <1609199500.0.0.590349255372.issue42772@roundup.psfhosted.org> |
2020-12-28 23:51:39 | rhettinger | link | issue42772 messages |
2020-12-28 23:51:39 | rhettinger | create | |
|