Message 382974 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	epaine
Recipients	epaine, serhiy.storchaka, shippo_
Date	2020-12-14.10:20:57
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1607941257.81.0.0620935953494.issue42630@roundup.psfhosted.org>
In-reply-to

Content
+1 I agree the current AttributeError is not suitable. I would just copy the code from Lib/tkinter/__init__.py:2524 (or even better: refactor it into its own method to avoid duplication). The code there, though, would raise a similar AttributeError if the default root is disabled, so I suggest that needs a changing to possibly a TypeError (i.e. missing 'master' argument). I assume you are alright to create a PR for this? Please revert the "resolution" field as this is intended to be the reason for issue closure.

+1 I agree the current AttributeError is not suitable.

I would just copy the code from Lib/tkinter/__init__.py:2524 (or even better: refactor it into its own method to avoid duplication). The code there, though, would raise a similar AttributeError if the default root is disabled, so I suggest that needs a changing to possibly a TypeError (i.e. missing 'master' argument). I assume you are alright to create a PR for this?

Please revert the "resolution" field as this is intended to be the reason for issue closure.

History
Date	User	Action	Args
2020-12-14 10:20:57	epaine	set	recipients: + epaine, serhiy.storchaka, shippo_
2020-12-14 10:20:57	epaine	set	messageid: <1607941257.81.0.0620935953494.issue42630@roundup.psfhosted.org>
2020-12-14 10:20:57	epaine	link	issue42630 messages
2020-12-14 10:20:57	epaine	create