This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients ZackerySpytz, espie, rhettinger, serhiy.storchaka, skrah, vstinner
Date 2020-12-05.01:28:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1607131713.14.0.578731712611.issue30459@roundup.psfhosted.org>
In-reply-to
Content
I propose to merge my PR 23645 change right now. If it breaks too many C extensions, we still have time before Python 3.10.0 final scheduled at Monday, 2021-10-04, to revert the change.


"if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0)"

Well, this is obviously a bug in py-qt4 and it's a good thing to get a compiler error on such code. I guess that the intent was to use PyList_SetItem().

It's also an issue for Python implementation other than CPython which does not behave exactly like CPython C API. I prefer to fix the C API to make it respect its own documentation (return "void").


Espie Marc: "Well, there is not going to be a lot of breakage. This problem is the only instance I've encountered in the full OpenBSD ports tree."

Oh, thanks for providing this very useful feedback! That's very promising.

Did you report the issue to py-qt4 upstream? If yes, can you please copy here the link to your report?
History
Date User Action Args
2020-12-05 01:28:33vstinnersetrecipients: + vstinner, rhettinger, skrah, serhiy.storchaka, espie, ZackerySpytz
2020-12-05 01:28:33vstinnersetmessageid: <1607131713.14.0.578731712611.issue30459@roundup.psfhosted.org>
2020-12-05 01:28:33vstinnerlinkissue30459 messages
2020-12-05 01:28:32vstinnercreate