Message381909
+0
Do you want to submit a PR for this?
Some thoughts:
* The current logic matches the logic before the warning was added.
* The proposed logic matches what the code will do after the
deprecation period (it will only check for non-sequences).
* There is some value in the warning in that it lets you know an
inefficient code path is being used (i.e. the conversion to a tuple).
* The proposed logic doesn't just change the warning, it changes
what actually happens to the data. IMO the change is for the
better, but it is a behavior change and could potentially cause
a failure in someone's code.
* The case of an object that is both a sequence and a set is
likely very rare. |
|
Date |
User |
Action |
Args |
2020-11-26 19:16:47 | rhettinger | set | recipients:
+ rhettinger, tim.peters, xmorel |
2020-11-26 19:16:47 | rhettinger | set | messageid: <1606418207.32.0.455663567322.issue42470@roundup.psfhosted.org> |
2020-11-26 19:16:47 | rhettinger | link | issue42470 messages |
2020-11-26 19:16:46 | rhettinger | create | |
|