Author terry.reedy
Recipients eric.araujo, lkcl, rpetrov, schmir, terry.reedy
Date 2020-10-22.21:22:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1603401760.4.0.33195854284.issue5043@roundup.psfhosted.org>
In-reply-to
Content
The claimed bug is that when msc_pos is -1 in the code as posted, 'return []' should be executed, but None is returned instead.  When I add 'msc_pos = -1 before the if statement, and call the function, after adding the needed sys import, [] is indeed returned.

The final elif return has two bugs, '%i' and 'Ver':
raise ValueError("Unknown MS Compiler version %i " % msc_Ver)  # Posted
raise ValueError("Unknown MS Compiler version %s " % msc_ver)  # Fixed

With this fix and without -1 forced, the ValueError is raised on all current versions, so this code is out of date in any case.
History
Date User Action Args
2020-10-22 21:22:40terry.reedysetrecipients: + terry.reedy, lkcl, schmir, eric.araujo, rpetrov
2020-10-22 21:22:40terry.reedysetmessageid: <1603401760.4.0.33195854284.issue5043@roundup.psfhosted.org>
2020-10-22 21:22:40terry.reedylinkissue5043 messages
2020-10-22 21:22:40terry.reedycreate