Message 377951 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	iritkatriel
Recipients	iritkatriel, miss-islington, pitrou, udalrich.schermer, vinay.sajip
Date	2020-10-04.15:51:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1601826673.74.0.182250157017.issue41898@roundup.psfhosted.org>
In-reply-to

Content
I'm not sure my patch completely resolved this issue. I'm adding Antoine re the OP's question about the assertLogs API. > Doing so would make the test over-specific and fragile. The requirement is > that a warning be logged, not that a specific logger issue the warning. My view is that your test is fragile because it just asks "was anything logged" without checking the log message. The docs show how to verify that the log message is what you expect it to be.

I'm not sure my patch completely resolved this issue. I'm adding Antoine re the OP's question about the assertLogs API. 

> Doing so would make the test over-specific and fragile.  The requirement is > that a warning be logged, not that a specific logger issue the warning.

My view is that your test is fragile because it just asks "was anything logged" without checking the log message. The docs show how to verify that the log message is what you expect it to be.

History
Date	User	Action	Args
2020-10-04 15:51:13	iritkatriel	set	recipients: + iritkatriel, vinay.sajip, pitrou, miss-islington, udalrich.schermer
2020-10-04 15:51:13	iritkatriel	set	messageid: <1601826673.74.0.182250157017.issue41898@roundup.psfhosted.org>
2020-10-04 15:51:13	iritkatriel	link	issue41898 messages
2020-10-04 15:51:13	iritkatriel	create