Author steve.dower
Recipients steve.dower, tkmk
Date 2020-07-01.17:06:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1593623160.72.0.478399291852.issue41180@roundup.psfhosted.org>
In-reply-to
Content
I like using the existing event for unmarshalling code objects, assuming we have all the arguments available.

I'm not sure whether it's worth auditing all marshal.load() calls (just as we don't audit all pickle.load() calls). But depending on the code paths we may not have a choice.

Auditing the .pyc import twice (or more) is basically unavoidable, but it's not terrible anyway. When no hooks are set, it's negligible impact, and when someone adds a hook they are in control of how much work it does. Providing both events means they can choose to only handle one and still get the coverage.

Marking this as easy (C), since the hardest part is just going to be finding the right place to add the PySys_Audit call.
History
Date User Action Args
2020-07-01 17:06:00steve.dowersetrecipients: + steve.dower, tkmk
2020-07-01 17:06:00steve.dowersetmessageid: <1593623160.72.0.478399291852.issue41180@roundup.psfhosted.org>
2020-07-01 17:06:00steve.dowerlinkissue41180 messages
2020-07-01 17:06:00steve.dowercreate