This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lys.nikolaou
Recipients gvanrossum, lys.nikolaou, pablogsal
Date 2020-05-18.10:52:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1589799160.45.0.969493803644.issue40669@roundup.psfhosted.org>
In-reply-to
Content
Running the PEG Parser benchmarks requires having memory_profiler installed.

In Tools/peg_generator:

➜  peg_generator git:(master) make time_stdlib
../../python -m zipfile -e data/xxl.zip data
../../python scripts/benchmark.py --parser=cpython --target=xxl compile
Traceback (most recent call last):
  File "/home/lysnikolaou/repos/cpython/Tools/peg_generator/scripts/benchmark.py", line 9, in <module>
    import memory_profiler
ModuleNotFoundError: No module named 'memory_profiler'

I propose to make that optional and only compute the timing benchmarks, in case memory_profiler is not available, since it's these benchmarks that are most important and most frequently run.
History
Date User Action Args
2020-05-18 10:52:40lys.nikolaousetrecipients: + lys.nikolaou, gvanrossum, pablogsal
2020-05-18 10:52:40lys.nikolaousetmessageid: <1589799160.45.0.969493803644.issue40669@roundup.psfhosted.org>
2020-05-18 10:52:40lys.nikolaoulinkissue40669 messages
2020-05-18 10:52:40lys.nikolaoucreate