➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author methane
Recipients FFY00, methane, xtreak
Date 2020-05-09.10:23:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAEfz+Tx_4HPGwk-=EXXoB1cTV1OVN3fh_wuqR1cH4L2i+z-BJQ@mail.gmail.com>
In-reply-to <1589015305.3.0.0340192081725.issue40551@roundup.psfhosted.org>
Content 
On Sat, May 9, 2020 at 6:08 PM Filipe Laíns <report@bugs.python.org> wrote:
>
> > * Travis-CI, at least, does test against "merge commit", not HEAD of PR branch.
>
> Where? https://github.com/python/cpython/blob/master/.travis.yml

https://docs.travis-ci.com/user/pull-requests/

"Rather than build the commits that have been pushed to the branch the
pull request is from, we build the merge between the source branch and
the upstream branch."

> * Automatically
> * Semi-automatically

Both are fine, but...

>
> Please note in both situations, automatically rebasing PRs *is* the first step. After that, it's just figuring out a suitable model to re-trigger the checks before merging.

Bot shouldn't use rebase, but merge master branch.
Rebase in pull request branch break the pull request sometime.
See this thread:
https://discuss.python.org/t/info-rebase-origin-master-push-f-workflow-corrupts-pull-request-rarely/2558/7
History
Date User Action Args
2020-05-09 10:23:34methanesetrecipients: + methane, xtreak, FFY00
2020-05-09 10:23:34methanelinkissue40551 messages
2020-05-09 10:23:34methanecreate