This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author sydefekt
Recipients dstufft, eric.araujo, paul.moore, steve.dower, sydefekt, tim.golden, zach.ware
Date 2020-04-02.18:00:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1585850431.84.0.195210252651.issue40158@roundup.psfhosted.org>
In-reply-to
Content
CPython provides a NuGet package as a mechanism to support non-installed Python distributions. The package includes MSBuild support to integrate with its build process.

The expressions on lines 32 and 33 in the file:

https://github.com/python/cpython/blob/master/PC/layout/support/props.py

are both missing closing parentheses, which results in literal text instead of the resolve file paths. This appears to be introduced in version 3.7.2 of the package onward, including the current pre-release 3.9.0-a5.

In addition, several build conditions use the form " $(Property) == 'value' ", but should instead use " '$(Property)' == 'value' ". By not surrounding the property value with '', the condition may resolve as "  == '' ", which is an invalid expression and will cause a build failure. This doesn't appear to have caused an issue yet, but it easily could.

If there is no further discussion or objection, I can submit a PR with the required fixes.
History
Date User Action Args
2020-04-02 18:00:31sydefektsetrecipients: + sydefekt, paul.moore, tim.golden, eric.araujo, zach.ware, steve.dower, dstufft
2020-04-02 18:00:31sydefektsetmessageid: <1585850431.84.0.195210252651.issue40158@roundup.psfhosted.org>
2020-04-02 18:00:31sydefektlinkissue40158 messages
2020-04-02 18:00:31sydefektcreate