Message365432
I don't think this makes the world better. It just makes it more intertwined. Currently, I can read the test code in isolation and understand it. But with the proposed PR, a person now needs to know more of what is in test_support. I really like seeing the classes in-line so I know exactly what they are doing and exactly what a test is doing.
Also, I don't like reinventing another alternative to mocks. Ideally, we want to minimize the number of things a person has to know in order to read and write our tests.
I understand your desire to factor everything you see, but in so doing you're creating tighter coupling and increasing complexity for the everyday contributor. |
|
Date |
User |
Action |
Args |
2020-03-31 22:33:29 | rhettinger | set | recipients:
+ rhettinger, mark.dickinson, serhiy.storchaka |
2020-03-31 22:33:29 | rhettinger | set | messageid: <1585694009.08.0.905168984325.issue40129@roundup.psfhosted.org> |
2020-03-31 22:33:29 | rhettinger | link | issue40129 messages |
2020-03-31 22:33:28 | rhettinger | create | |
|