This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alex.henrie
Recipients alex.henrie, christian.heimes
Date 2020-01-09.04:27:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1578544064.68.0.445985334082.issue39272@roundup.psfhosted.org>
In-reply-to
Content
The function _ssl__SSLContext_load_verify_locations_impl currently contains the following code:

        if (r != 1) {
            ok = 0;
            if (errno != 0) {
                ERR_clear_error();
                PyErr_SetFromErrno(PyExc_OSError);
            }
            else {
                _setSSLError(NULL, 0, __FILE__, __LINE__);
            }
            goto error;
        }
    }
    goto end;

  error:
    ok = 0;

It is unnecessary to set ok to 0 before jumping to error because the first instruction after the error label does the same thing.
History
Date User Action Args
2020-01-09 04:27:44alex.henriesetrecipients: + alex.henrie, christian.heimes
2020-01-09 04:27:44alex.henriesetmessageid: <1578544064.68.0.445985334082.issue39272@roundup.psfhosted.org>
2020-01-09 04:27:44alex.henrielinkissue39272 messages
2020-01-09 04:27:44alex.henriecreate