Message 359083 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	methane
Recipients	LCatro, corona10, methane, pablogsal, serhiy.storchaka
Date	2019-12-31.01:43:00
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1577756580.92.0.505690531816.issue38588@roundup.psfhosted.org>
In-reply-to

Content
>> This makes list comparison 2x slower. > > This is affected by PR 17734? or PyObject_RichCompare patched? Caused by PR 17734. > Would you like to revert PR 17734? Calling Py_INCREF and Py_DECREF in PyObject_RichCompare or do_richcompare will take the same effect, no? Moving INCREF and DECREF is a huge change. It is just a future idea to prevent same type of bugs. I think it can not be backported. To fix this issue with minimum performance regression, I think PR 17766 is the best solution. So no need to revert PR 17734.

>> This makes list comparison 2x slower.
>
> This is affected by PR 17734? or PyObject_RichCompare patched?

Caused by PR 17734.


> Would you like to revert PR 17734? Calling Py_INCREF and Py_DECREF in PyObject_RichCompare or do_richcompare will take the same effect, no?

Moving INCREF and DECREF is a huge change.  It is just a future idea to prevent same type of bugs.  I think it can not be backported.

To fix this issue with minimum performance regression, I think PR 17766 is the best solution.  So no need to revert PR 17734.

History
Date	User	Action	Args
2019-12-31 01:43:00	methane	set	recipients: + methane, serhiy.storchaka, LCatro, corona10, pablogsal
2019-12-31 01:43:00	methane	set	messageid: <1577756580.92.0.505690531816.issue38588@roundup.psfhosted.org>
2019-12-31 01:43:00	methane	link	issue38588 messages
2019-12-31 01:43:00	methane	create